Remove dangling bonds with mincoordination
#131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130
Introduces a new
mincoordination
kwarg inunitcell(::Hamiltonian,...)
. This removes sites until all remaining have at leastmincoordination
neighbors. The way this works is we iterate over the mask of the supercell to eliminate any sites that have too few neighbors. This pass is repeated until no more sites are removed. As the neighbor searching reused a large part of non-trivial hamiltonian unitcell code, I had to refactor the latter so that functionality could be shared.Example from tests: